Added naps_fibers parameter as output #19
Conversation
Added naps_fibers as output + changes to commensurate test/benchmarks
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@robsc bit confused as to what has happened with the carfac_bench and whether I have overwritten a previous version of mine or something in the pipeline!! |
scrap that...I realize that you had generated a benchmark with "two_cap_with_syn" after I cloned the repo....will make changes accordingly!! |
carfac_fibers
python/jax/carfac.py
Outdated
| @@ -2352,6 +2354,7 @@ def run_segment( | |||
|
|
|||
| n_ch = hypers.ears[0].car.n_ch | |||
| naps = jnp.zeros((n_samp, n_ch, n_ears)) # allocate space for result | |||
| naps_fibers = jnp.zeros((n_samp, n_ch, 3, n_ears)) | |||
There was a problem hiding this comment.
Is this "3" the 3 from SynDesignParameters.n_classes ? I think it is, right?
If so, is it possible to reference that 3 by name instead of the constant here.
python/jax/carfac.py
Outdated
| v_recep, ear, weights, state.ears[ear].syn | ||
| ) | ||
| naps_fibers = naps_fibers.at[k, :, :, ear].set(firings) | ||
| else: | ||
| naps_fibers = naps_fibers.at[k, :, :, ear].set(jnp.zeros([jnp.shape(ihc_out)[0], 3])) |
There was a problem hiding this comment.
Same comment about the "3" here.
python/jax/carfac_bench.py
Outdated
| @@ -466,4 +466,4 @@ def bench_jax_util_mapped(state: google_benchmark.State): | |||
|
|
|||
|
|
|||
| if __name__ == '__main__': | |||
| google_benchmark.main() | |||
| google_benchmark.main() | |||
There was a problem hiding this comment.
Please restore the newline at end of file here.
…s parameter in carfac.py
carfac_fibers
Changes to carfac.py + commensurate test/benchmark files based on added output that represents naps for each fiber type